-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should all Colors class define the same color? #47
Comments
for what it is worth the 8 colors defined by ansi for terminals are, Black Red Green Yellow Blue Magenta Cyan White |
(also I should check but I don't think the Color class has any particular needs, so we might as well also make it am |
See #35 as well. |
Do all the themes have something like 8 ANSI colours + comment? @gabalafou @Carreau since you both looked at this recently. If so that would give us a relatively uniform palette for the themes. If not -- as in the themes have really different colours and no apparent base palette - then chaos reigns.
AFAIK there are no particular needs/requirements that must be met here so we cal always go down the |
Well roughly yes the themes use about the same colors. Things is the Color class itself is unnecessary for the theme, it is just used as a convenience to refer to a limited set of colors. I think it would make sens to have some consistency. I'll try to look at which themes differs from others. |
Colors used "only" in a few themes:
Colors "missing" in a few themes:
"Yellow" is present in 9 themes out of 16, so meh. |
Maybe this is something we should think about and have all define the same set of keys ?
Originally posted by @Carreau in #42 (comment)
The text was updated successfully, but these errors were encountered: