-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not enough space between the links in the "on this page" navigation #82
Comments
I don't need a Figma to implement this, but I think it would be great if somebody in design could tell me by exactly how much I should increase the space between the links, and then I'll implement it. |
Too long; didn't read: I would recommend we implement an additional 15 CSS pixels between the “On this page” navigation links. My rationale is in the paragraphs below the divider. For context, my rationale overlaps with what I’ve already explained in #81. To summarize
The main concern I have with the “On this page” navigation links is actually that I can’t find any space between clickable targets between the navigation list items (unlike the navbar buttons in #81 where there was still some non-clickable space between to start). When I move my cursor vertically, I cannot rest it anywhere between the list items and not have something hovered. Target sizes this tightly packed require a lot of motor skill precision to work as expected and make it very easy to misclick. When testing the overlap, I see about an equal number of pixels to the height of the target size overlapping, or about 27 CSS px. This makes sense to me considering the list items are almost back to back without spacing. Because I’m already extending a guideline beyond its original scope, the length of the buttons with the short height require tall ellipses, and I am aware of many buttons with less than their own height between them that are considered to have good spacing, I am fine adding a fraction of this overlap. I think adding ~15 CSS px spacing between “On this page” list items adds spacing and leaves about a default cursor height’s space to rest. |
Thanks @isabela-pf, I'm going to take over from here and move this from design to dev |
@isabela-pf, your suggestion for the on-this-page navigation makes sense to me, but when I implement what I think you're asking, the result makes the right sidebar table of contents no longer look in harmony with the left sidebar table of contents. Did I implement this incorrectly or do we need to think about adjusting the spacing for other navigation areas? |
Good question! We talked about it in the #117 today and I'll be summarizing what we discussed here:
|
Closing because pydata/pydata-sphinx-theme#1980 was merged. |
No description provided.
The text was updated successfully, but these errors were encountered: