Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the special demo and builtin option for the config? #124

Closed
pmeier opened this issue Oct 27, 2023 · 2 comments
Closed

Remove the special demo and builtin option for the config? #124

pmeier opened this issue Oct 27, 2023 · 2 comments
Labels
type: RFD ⚖️ Decision making

Comments

@pmeier
Copy link
Member

pmeier commented Oct 27, 2023

The original intention was to make it easier for the user to select these two without the need of a config file. However, it is beginning to dawn on me that this actually makes it more confusing:

By having builtin as default, starting the worker / API / UI without a config is possible. However, we are only including components for which the requirements are met. So if one does pip install ragna[builtin], they would only see the builtin source storages, since all assistants so far require an API key to be set as environment variable. Worse, if one does pip install ragna, the default builtin configuration is the same as demo, since now we likely not even meet the package requirements.

By removing the demo and builtin option and in turn require the -c / --config option, we would "force" users through the config wizard. And by that they should have a better understand what they are running.

@pmeier pmeier added the type: RFD ⚖️ Decision making label Oct 27, 2023
@smeragoel
Copy link

I think that makes sense, since we want them to go through the config to get a better understanding.

@pmeier
Copy link
Member Author

pmeier commented Nov 1, 2023

Closed in #125.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: RFD ⚖️ Decision making
Projects
None yet
Development

No branches or pull requests

2 participants