Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demo authentication should enforce a username #158

Closed
pmeier opened this issue Nov 2, 2023 · 2 comments
Closed

Demo authentication should enforce a username #158

pmeier opened this issue Nov 2, 2023 · 2 comments

Comments

@pmeier
Copy link
Member

pmeier commented Nov 2, 2023

There is no check for that. Worse, if running without a central password, not putting anything for username and password actually authenticates. Reported in #156 (reply in thread).

@pmeier pmeier added type: bug 🐛 Something isn't working area: rest-api 💻 labels Nov 2, 2023
@pmeier pmeier self-assigned this Nov 2, 2023
@pmeier pmeier added needs: discussion 💬 and removed type: bug 🐛 Something isn't working labels Nov 2, 2023
@pmeier
Copy link
Member Author

pmeier commented Nov 2, 2023

On second thought, maybe this is actually a good thing? Like, if users don't configure anything they are still hit by the authentication screen. Being able to just click "Login" without filling in anything, could count as feature?

@pmeier
Copy link
Member Author

pmeier commented Aug 2, 2024

On third thought, I agree with my initial statement. As proposed in #179, the dummy authentication should not be the default and thus it is ok to require a username being supplied.

@pmeier pmeier moved this from Todo to Done in Ragna ⛵️ Dec 11, 2024
@pmeier pmeier closed this as completed Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

1 participant