-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] - Limit displayed document pills in header #224
Comments
That is not going to happen. Having the documents used for the chat visible by default is intended. Instead what we should do in this case is truncate the number of visible documents. The full number is still visible when clicking the chat info button.
This is special to your use case of having the whole corpus of documents active at once. In there I would even say the number of documents shouldn't even displayed as it provides no value to the user. It becomes more and more clear that we need to support this use case in general. Will open an issue about this soon. It seems that you are using |
Your take on the situation sounds reasonable. My colleague, @Tengal-Teemo, plans to post some of his insights into the performance of Ragna's UI in the discussion section sometime this week. Those insights might be helpful in making sure the UI stays responsive across a variety of conditions. As far as data connectors are concerned, {"text": "..."}
{"text": "..."}
{"text": "..."} |
Thanks a ton 🚀
I've opened #225.
Could you open an issue for that. I'm not familiar with the format. |
I've added a hard limit for 20 visible documents in #235. This doesn't solve any of the graphics issues raised here, but at least prevents performance hits when one is using a large number of documents. |
Feature description
When there are a lot of documents underlying a chat, the chat header becomes unwieldy. It might be better to display the total number of documents underlying the chat in the header than all of their filenames.
Value and/or benefit
Removing the
chat_document_pills
greatly improves client-side performance when dealing with large corpora.Anything else?
I've had to comment out the following lines of code to make my system performant:
ragna/ragna/_ui/central_view.py
Lines 596 to 623 in 3d8541f
The text was updated successfully, but these errors were encountered: