-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#391 Chat Ordering based upon the order of interaction #445
Conversation
@blakerosenthal Could you check if this change is indeed enough? |
This doesn't quite work, unfortunately. Option 1: add a (created_at) timestamp to Chats and then add an |
I'd prefer option 1. by a big margin. |
Thanks a lot for confirming on this @blakerosenthal, the ui tests you added were also very helpful to test in #446 🚀 |
Hi @blakerosenthal, happy to have your quick look again on this. Thanks 🙂 |
Co-authored-by: Blake R <blakepdx@protonmail.com>
daa09fe
to
67de21b
Compare
I'm ok with limiting the scope of this change to only adapt the order when the page (re-)loaded. But ultimately, we want the ordering change to be dynamic, e.g. if I ask a new question in an old chat, that should automatically move to the top of the list rather than this only happening the next time I load the page. @arjxn-py or @blakerosenthal could one of you open a new issue for this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks Arjun!
This PR modifies the
LeftSidebar
component to display chats in reverse order, showing the newest chats first instead of the oldest.Should fix #391