Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix E2E test on Windows #447

Open
blakerosenthal opened this issue Jul 11, 2024 · 0 comments
Open

Fix E2E test on Windows #447

blakerosenthal opened this issue Jul 11, 2024 · 0 comments
Labels
type: bug 🐛 Something isn't working

Comments

@blakerosenthal
Copy link
Contributor

Bug description

Currently the test in tests/deploy/api/test_e2e.py is broken on Windows. The API call to /chats/<chat id> often (not always) fails to include the previous user message immediately after a call to /chats/<chat id>/answer. We need to investigate where this message is being dropped.

How to reproduce the bug?

See https://github.com/Quansight/ragna/actions/runs/9891178695/job/27321052554?pr=438#step:4:169
Can reproduce by uncommenting @skip_on_windows in /tests/deploy/api/test_e2e.py.

Versions and dependencies used

No response

Anything else?

No response
@blakerosenthal blakerosenthal added the type: bug 🐛 Something isn't working label Jul 11, 2024
@blakerosenthal blakerosenthal mentioned this issue Jul 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug 🐛 Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@blakerosenthal