Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove API wrapper #521

Open
pmeier opened this issue Dec 20, 2024 · 0 comments · May be fixed by #525
Open

remove API wrapper #521

pmeier opened this issue Dec 20, 2024 · 0 comments · May be fixed by #525
Assignees

Comments

@pmeier
Copy link
Member

pmeier commented Dec 20, 2024

Before #509, the API wrapper

class ApiWrapper(param.Parameterized):

made sense, since it gave as a convenient interface around our own REST API. However, after #509 the API wrapper no longer wraps a REST API, but rather a subset of the engine

class Engine:

Thus, we can cleanup the UI code quite a bit by removing the API wrapper completely and just use the engine directly.

@smokestacklightnin smokestacklightnin self-assigned this Dec 24, 2024
@smokestacklightnin smokestacklightnin linked a pull request Dec 26, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants