Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move offset from columns to index in benchmark reported results #346

Closed
ElizabethSantorellaQC opened this issue Feb 11, 2021 · 0 comments · Fixed by #408
Closed

Move offset from columns to index in benchmark reported results #346

ElizabethSantorellaQC opened this issue Feb 11, 2021 · 0 comments · Fixed by #408

Comments

@ElizabethSantorellaQC
Copy link
Contributor

When using benchmarks to check for correctness, we should only compare problems that have the same solution. For the binomial family, different offsets should yield different solutions, so we shouldn't be comparing offset and non-offset problems to each other. This can be achieved by moving 'offset' from the columns to the index of reported results, as Philipp did here:

#344 (comment)_

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant