Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Benchmark additions #376

Merged
merged 7 commits into from
Sep 22, 2021
Merged

Benchmark additions #376

merged 7 commits into from
Sep 22, 2021

Conversation

MargueriteBastaQC
Copy link
Contributor

@MargueriteBastaQC MargueriteBastaQC commented May 18, 2021 •
edited by tbenthompson
Loading

Checklist

  • Added a CHANGELOG.rst entry

@MargueriteBastaQC MargueriteBastaQC marked this pull request as draft May 18, 2021 19:46
@MargueriteBastaQC MargueriteBastaQC changed the title Benchmark additions WIP Benchmark additions May 18, 2021
@MargueriteBastaQC
Copy link
Contributor Author

@tbenthompson CI tests fail right now because there aren't golden master entries for the new tests. Would best practice here be to just add the new tests directly to benchmark_glm.json?

@tbenthompson tbenthompson marked this pull request as ready for review August 25, 2021 23:05
@tbenthompson
Copy link
Collaborator

I fixed up this old PR that we dropped and never came back to. It seems quite useful for getting a second benchmark problem to make some nice figures in the docs.

@MarcAntoineSchmidtQC mind taking a quick look?

@tbenthompson
Copy link
Collaborator

Also, thanks @MargueriteBastaQC !!!

@tbenthompson tbenthompson changed the title WIP Benchmark additions Benchmark additions Aug 26, 2021
MarcAntoineSchmidtQC
MarcAntoineSchmidtQC approved these changes Aug 26, 2021
View reviewed changes
Copy link
Member

@MarcAntoineSchmidtQC MarcAntoineSchmidtQC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Do we want to add a changelog entry for this?

@tbenthompson tbenthompson merged commit d01168e into master Sep 22, 2021
@tbenthompson tbenthompson deleted the benchmark-additions branch September 22, 2021 21:46
@tbenthompson tbenthompson mentioned this pull request Sep 23, 2021
Closed
tbenthompson added a commit that referenced this pull request Oct 8, 2021
@MargueriteBastaQC @tbenthompson
Benchmark additions (#376)
4ee81ac 
* add boston housing data

* Add golden master output. Delete dead code.

* Update create_housing.py

* Changelog

Co-authored-by: Ben Thompson <t.ben.thompson@gmail.com>
tbenthompson added a commit that referenced this pull request Oct 8, 2021
@MargueriteBastaQC @tbenthompson
Benchmark additions (#376)
84a9596 
* add boston housing data

* Add golden master output. Delete dead code.

* Update create_housing.py

* Changelog

Co-authored-by: Ben Thompson <t.ben.thompson@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcAntoineSchmidtQC MarcAntoineSchmidtQC MarcAntoineSchmidtQC approved these changes

@tbenthompson tbenthompson Awaiting requested review from tbenthompson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MargueriteBastaQC @tbenthompson @MarcAntoineSchmidtQC