Add support for loading shmoverride into Xwayland too #151
Conversation
Add a wrapper that sets LD_PRELOAD=.../shmoverride.so. Since suid binaries are not involved with Xwayland, it can be a simple shell script. Place the wrapper as Xwayland in /usr/libexec/qubes/wrappers. Processes that are supposed to use it need to have /usr/libexec/qubes/wrappers prepended to PATH. QubesOS/qubes-issues#8515
If shmoverride init fails to take the lock, it likely means it is used by currently running process - do _not_ remove the file in such a case. This may happen if LD_PRELOAD leaks to child processes (which seems to happend on Xwayland when shmoverride is linked with -z initfirst). But also, if X server is started several times for some reason (for example user calls it manually), it will abort, but not early enough to skip shmoverride init. QubesOS/qubes-issues#8515
marmarek
force-pushed
the
xwayland-wrap
branch
from
c61854b to
5873084
Compare
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024101803-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024091704-4.3&flavor=update
Failed tests10 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/112766#dependencies 198 fixed
Unstable tests
|
This is initial version that uses a wrapper. Draft PR, as alternative solution may be better (add env variable controlling which process to handle).
QubesOS/qubes-issues#8515