Expert to Novice Transition #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
QuentinRoy
commented
Aug 24, 2018
•
QuentinRoy
commented
- model tests
- navigation switch tests
- implementation
Codecov Report
@@ Coverage Diff @@
## master #34 +/- ##
=========================================
- Coverage 94.83% 92.9% -1.93%
=========================================
Files 18 19 +1
Lines 387 409 +22
Branches 52 60 +8
=========================================
+ Hits 367 380 +13
- Misses 20 26 +6
- Partials 0 3 +3
Continue to review full report at Codecov.
|
QuentinRoy
force-pushed
the
mark-confirmation
branch
from
39ab077 to
f058214
Compare
Codecov Report
@@ Coverage Diff @@
## master #34 +/- ##
==========================================
+ Coverage 98.96% 99.02% +0.05%
==========================================
Files 19 20 +1
Lines 388 410 +22
Branches 52 60 +8
==========================================
+ Hits 384 406 +22
Misses 4 4
Continue to review full report at Codecov.
|
QuentinRoy
force-pushed
the
mark-confirmation
branch
2 times, most recently
from
668ce97 to
7cf4f54
Compare
Menu used to crash when trying to open a menu from a leaf on any level > 1.
Start of the stroke was being ignored.
QuentinRoy
force-pushed
the
mark-confirmation
branch
from
7cf4f54 to
ee2612c
Compare
QuentinRoy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.