#125: optimize EntityTag syntax (#126)

#125: optimize EntityTag syntax
Quillraven · Nov 27, 2023 · 4d20d3d · 4d20d3d
1 parent 3ba9640
commit 4d20d3d
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 2 deletions.
diff --git a/src/commonMain/kotlin/com/github/quillraven/fleks/entity.kt b/src/commonMain/kotlin/com/github/quillraven/fleks/entity.kt
@@ -141,7 +141,7 @@ open class EntityCreateContext(
     /**
      * Sets the [tag][EntityTag] to the [entity][Entity].
      */
-    operator fun Entity.plusAssign(tag: UniqueId<*>) {
+    operator fun Entity.plusAssign(tag: EntityTags) {
         compMasks[this.id].set(tag.id)
         // We need to remember used tags in order to correctly return and load them using
         // the snapshot functionality, because tags are not managed via ComponentHolder and
@@ -154,7 +154,7 @@ open class EntityCreateContext(
      * Sets all [tags][EntityTag] on the given [entity][Entity].
      */
     @JvmName("plusAssignTags")
-    operator fun Entity.plusAssign(tags: List<UniqueId<*>>) {
+    operator fun Entity.plusAssign(tags: List<EntityTags>) {
         tags.forEach { this += it }
     }
 

diff --git a/src/commonTest/kotlin/com/github/quillraven/fleks/EntityTagTest.kt b/src/commonTest/kotlin/com/github/quillraven/fleks/EntityTagTest.kt
@@ -154,4 +154,22 @@ class EntityTagTest {
             }
         }
     }
+
+    /*
+    fun syntaxCheck() {
+        val world = configureWorld {}
+        world.entity {
+            it += TestTags.PLAYER
+            it += Visible
+            it += listOf(Visible)
+            it += TestTags.entries
+            it += listOf(Visible, TestTags.PLAYER)
+
+            it += TestTagComponent()
+            it += listOf(TestTagComponent())
+
+            it += TestTagComponent // <-- should not compile
+        }
+    }
+     */
 }