feat(megaparse): add sdk #3462
Merged
feat(megaparse): add sdk #3462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:L
Closed
AmineDiro
previously approved these changes
Nov 7, 2024
There was a problem hiding this comment.
Thx for the PR ! I think we should also have fallback tests. By default we will always choose megaparse class in registry but if we can't instanciate the class we would probably need something else.
We probably need to see if we keep the registry around for quivr-core
| AUTO = "auto" | ||
| HI_RES = "hi_res" | ||
|
|
||
|
|
||
| class MegaparseBaseConfig(BaseModel): |
There was a problem hiding this comment.
Why do we need to configure it from yaml ?
StanGirard
approved these changes
Nov 8, 2024
StanGirard
added a commit
that referenced
this pull request
Nov 18, 2024
🤖 I have created a release *beep* *boop* --- ## [0.0.24](core-0.0.23...core-0.0.24) (2024-11-14) ### Features * kms-migration ([#3446](#3446)) ([1356d87](1356d87)) * **megaparse:** add sdk ([#3462](#3462)) ([190d971](190d971)) ### Bug Fixes * added chunk_size in tika processor ([#3466](#3466)) ([063bbd3](063bbd3)) * modify megaparse strategy ([#3474](#3474)) ([da97b2c](da97b2c)) * supported extensions for megaparse ([#3477](#3477)) ([72b979d](72b979d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does :
Adds the MegaParse API call for parsing using the SDK