Wrong tzinfo_tz value stored in database

[atruskie]

It appears that the wrong value is persisted to the database for the tzinfo_tz value.

Instead of Australia/Sydney being stored, the friendly value Australia - Sydney value is stored.

This causes exceptions when we try and decode the value in the new code from #262 - particularly this line https://github.com/QutBioacoustics/baw-server/blob/6571c40259dff1643778472e7e7d8ea911120935/lib/modules/time_zone_helper.rb#L98

Confirmed problem by manually changing value in database - no longer causes exceptions.

Further:

• this problem affects the timezones for sites as well as users
• invalid formats are stored in the production database for both users and sites
• fixing this will require running a migration or a script
• this issue is blocking a prod deploy

[cofiem]

Instead of having to change prod db, I just converted to tzinfo id from tz info friendly id when rendering.

There are also a bunch more tests.

[atruskie]

Question - are the proper values now stored?

[cofiem]

As far as I can see, it doesn't matter whether we store identifier or friendly identifier. Only issue might be ambiguity in friendly identifiers, but so far I can't see where that would happen. It's easy enough to convert between friendly_identifier and identifier.

The extra tests I added should help catch any problems already stored in db. I also added a validation to the rails forms - the form will force user to change invalid timezone name before the form will successfully submit.