Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in obfuscation of lat/long #91

Closed
1 of 3 tasks
atruskie opened this issue Apr 16, 2014 · 3 comments
Closed
1 of 3 tasks

Error in obfuscation of lat/long #91

atruskie opened this issue Apr 16, 2014 · 3 comments

Comments

@atruskie
Copy link
Member

Reported by Dez:

Latitude – Longitude appears to be randomising before obfuscating. This is producing a misplacement of the Lat-Long greater than the code originally was set for of 10m. The error appears to be up to 100km

  • Double check the unit tests - we're meant to be rounding to nearest ±20m
  • Possibly: store the jittered location so it does not move around
    • may not need to once it jitters correctly (the moving effect would be small)
  • Possibly: remove jitter for users with write permissions

Confirmed by @AntMt

@cofiem
Copy link
Contributor

cofiem commented Apr 23, 2014

Updated unit tests to actually test for rounding (based on ~10m accuracy at 0.0001 degrees).
Jitter is not stored, only calculated, and still applies for users with write permissions.

@cofiem
Copy link
Contributor

cofiem commented Dec 18, 2014

Lat/longs for site do not seem to be obfuscated since Rails4 migration.

@cofiem
Copy link
Contributor

cofiem commented Mar 13, 2015

Fixed in cf1a88b

@cofiem cofiem closed this as completed Mar 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants