Refactoring and standardizing secondary menus #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #242 Also adds a `data-message-type` attribute to the alert DOM to make future debugging of flashes easier.
Allows this method to never execute the projects query when the current user is the admin user.
- label placement is now automatic - made helper link functions for new, edit, delete, and visualize - almost completed site page - add a custom 'annotation' icon - removed unnecessary association for `update_location_obfuscated` - added and info_bar widget partial for the right hand side actions bar - refactored common link cruft into _nav_buton.html.haml and _nav_item.html.haml
Work for #275 . There are lots of changes. There are still links that need to be cleaned up in the admin section. There likely is a better way to do a lot of this too. In paritcular I'm thinking some kind of MVVM methodolgy (where view specific variables can be defined in code for entire folders). Even so, a lot of helper functions have been defined that will ensure consistency of menu links. However we need to ship, so smaller changes/refactors/fixes will be done at a later time.
atruskie
changed the title
atruskie
changed the title
atruskie
changed the title
atruskie
added a commit
to QutEcoacoustics/baw-client
that referenced
this pull request
Feb 10, 2017
baw-server updated it's navigation to the new design style but also overtook where we left the client. These changes bring both designs to parity. See QutEcoacoustics/baw-server#313 Addresses #260
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #275
This PR is probably 33% complete
Closes #275