Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nullable license field to Projects model #669

Merged
merged 1 commit into from
Jan 16, 2024
Merged

Conversation

hudson-newey
Copy link
Member

@hudson-newey hudson-newey commented Jan 15, 2024

Add nullable license field to Projects model

Given that projects can be publically available for viewing, users have commonly associated usage rights and licensing information with the projects. However, with existing API capabilities, this information is usually encoded in the description field.

The addition of a specific license attribute on projects will allow uses to either: Reference an SPDX license code or insert a custom license as free form text.

Changes

  • Adds a license filed to project models

Issues

Fixes: #289

Problems

None

Visual Changes

None

Final Checklist

  • Assign reviewers if you have permission
  • Assign labels if you have permission
  • Link issues related to PR
  • Remove/Reduce warnings from edited files
  • Unit tests have been added for changes
  • Ensure CI build is passing

Copy link
Member

@atruskie atruskie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

Like we discussed, at some point in the future it might be nice to know programmatically which projects use an open license, server side. But for now, we don't have a clear use case for the added complexity and I anticipate we can do an uplift later when it is needed.

@atruskie atruskie merged commit 40eb800 into master Jan 16, 2024
2 of 4 checks passed
@atruskie atruskie deleted the project-licenses branch January 16, 2024 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Encode license and attribution information in project models
2 participants