Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

partytownVite not copying lib files to destination #367

Closed
1 task done
cesarnml opened this issue Feb 13, 2023 · 1 comment
Closed
1 task done

partytownVite not copying lib files to destination #367

cesarnml opened this issue Feb 13, 2023 · 1 comment

Comments

@cesarnml
Copy link

cesarnml commented Feb 13, 2023

  • I am interested in helping provide a fix!

Describe the bug
The SvelteKit integration guide doesn't work because partytownVite does not copy lib code to static/~partytown.

To Reproduce
Steps to reproduce the behavior:

  1. Follow theSvelteKit integration guide
  2. Deploy to production.
  3. Go to production site.
  4. Open Network console and verify that fetching partytown-sw.js results in a 404.

Reproduction link
https://github.com/cesarnml/partytown-bug/tree/a355b77659232e703cd246a0c908eb8ddf034a0d

Expected behavior
I expected partytownVite to copy lib code to /static/~partytown/

Partytown version
What version of Partytown you are using, e.g. 0.7.5

Screenshots
Screenshot 2023-02-13 at 08 46 06

@cesarnml cesarnml changed the title partytownVite util not copying lib code to destination partytownVite not copying lib files to destination Feb 13, 2023
@multiplehats
Copy link

multiplehats commented Feb 25, 2023

Same issue here!

A fix for now is to just copy the files over during build:

"build": "pnpm partytown && vite build",
"partytown": "partytown copylib static/~partytown",

@cesarnml cesarnml closed this as not planned Won't fix, can't repro, duplicate, stale Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants