Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove the httr dependency #239

Open
mcol opened this issue Sep 12, 2024 · 1 comment
Open

remove the httr dependency #239

mcol opened this issue Sep 12, 2024 · 1 comment
Labels
enhancement refactoring Code refactoring to improve performance and/or stability
Milestone
Release version 1...

Comments

@mcol
Copy link
Contributor

mcol commented Sep 12, 2024

We use these functions from the httr package:

  • accept_json() in github_getContent()
  • content() in github_getContent() and use_DRAC()
  • http_error() in read_SPE2R()
  • status_code() in github_getContent() and use_DRAC()
  • GET() in github_getContent()
  • POST() in use_DRAC()
@mcol mcol added enhancement refactoring Code refactoring to improve performance and/or stability labels Sep 12, 2024
@mcol mcol added this to the Release version 1.0.0 milestone Sep 12, 2024
@RLumSK
Copy link
Member

RLumSK commented Dec 7, 2024

@mcol I think we concluded that this is something we don't touch anymore, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement refactoring Code refactoring to improve performance and/or stability
Projects
None yet
Milestone
Release version 1.0.0
Development

No branches or pull requests
2 participants
@mcol @RLumSK