-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement HTTP requests for Squirrel scripts #344
Conversation
# Conflicts: # NorthstarDLL/NorthstarDLL.vcxproj # NorthstarDLL/NorthstarDLL.vcxproj.filters
# Conflicts: # NorthstarDLL/NorthstarDLL.vcxproj # NorthstarDLL/NorthstarDLL.vcxproj.filters
…tarLauncher into squirrel-http-main
Rebasing murdered the history a little, oh well. |
Feature complete, fixing format errors, and I'll also write the Squirrel side before we can consider reviewing and merging. |
Requires the Squirrel side first, making a PR later, don't merge this yet! |
Set to draft to prevent accidental merge |
Ready for review. |
This is especially useful when the host's ssl cert is invalid, or when testing in development for things like APIs running on localhost and the API refuses non-HTTPs requests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review looks good, just a few small things. Will test and re-review once these issues are resolved
Requires R2Northstar/NorthstarMods#531.
This PR aims to allow Squirrel scripts to make HTTP requests. This would allow them to do things like query APIs, send data to a server to save and more.
All HTTP request methods are supported. However, the following limitations apply:
The above limitations are for security reasons. If for some reason, you need access to private network addresses or IPv6 hosts, you may start the game with
-allowlocalhttp
to bypass those checks.You can also opt-out of letting mods use HTTP requests by starting your game with
-disablehttprequests
.Checklist
-allowlocalhttp
.Example
I will be simplifying the functions a little bit, but for now, this is how it looks:
Screenshots.