Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UI VM Destruction #349

Merged
merged 3 commits into from
Dec 9, 2022
Merged

Conversation

emma-miler
Copy link
Member

@emma-miler emma-miler commented Nov 27, 2022

Fixes a bug with UI VM destruction. The functions in question take a CSquirrelVM* instead of an HSquirrelVM*, which causes IsUIVM() always returns false.

@GeckoEidechse
Copy link
Member

Fixes @BobTheBob9 code :>

Co-authored-by: GeckoEidechse <40122905+GeckoEidechse@users.noreply.github.com>
@GeckoEidechse GeckoEidechse added needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code labels Nov 27, 2022
@GeckoEidechse GeckoEidechse mentioned this pull request Nov 27, 2022
@pg9182 pg9182 merged commit 778c935 into R2Northstar:main Dec 9, 2022
@emma-miler emma-miler deleted the fix-ui-vm-destroy branch December 11, 2022 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs code review Changes from PR still need to be reviewed in code needs testing Changes from the PR still need to be tested
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants