Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CGlobals class and g_pGlobals, and update code to support #411

Merged
merged 6 commits into from
Feb 12, 2023

Conversation

BobTheBob9
Copy link
Member

adds the CGlobals class and global pointer g_pGlobals, contains a few useful engine vars that we can use in preexisting code (code has been updated to do so)

@BobTheBob9 BobTheBob9 changed the title add CGlobals class and g_pGlobals, and update scripts to support add CGlobals class and g_pGlobals, and update code to support Feb 7, 2023
Copy link
Contributor

@RoyalBlue1 RoyalBlue1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and it seems to run fine

Copy link
Member

@GeckoEidechse GeckoEidechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving without proper review per request from @BobTheBob9 to merge. @RoyalBlue1 already looked at it anyway.

@GeckoEidechse GeckoEidechse changed the title add CGlobals class and g_pGlobals, and update code to support Add CGlobals class and g_pGlobals, and update code to support Feb 11, 2023
@BobTheBob9 BobTheBob9 merged commit 95b41b6 into main Feb 12, 2023
@BobTheBob9 BobTheBob9 deleted the cglobalvars-pr branch February 12, 2023 21:15
GeckoEidechse added a commit that referenced this pull request Apr 7, 2023
ASpoonPlaysGames added a commit to ASpoonPlaysGames/NorthstarLauncher that referenced this pull request Apr 7, 2023
GeckoEidechse pushed a commit that referenced this pull request Apr 7, 2023
Signed-off-by: GeckoEidechse <gecko.eidechse+git@pm.me>
GeckoEidechse pushed a commit that referenced this pull request Apr 8, 2023
GeckoEidechse pushed a commit that referenced this pull request Apr 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants