Revert "Update libcurl to 8.4.0 (#568)" #574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GeckoEidechse since this is a revert, is there any testing needed? |
newer releases of libcurl break the docker container This reverts commit 99c5c86.
nope, should not be necessary |
|
well actually maybe we should double check that docker image actually runs with this tbh |
|
Image for testing |
GeckoEidechse
approved these changes
Oct 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
newer releases of libcurl break the docker container
Its been triaged to only occur within the container so it can be argued that its not a general wine issue.
Since the CVE 8.4.0 fixes does not affect us, even if someone sets the environment variable, its fine to downgrade until the container situation is fixed or migrated
TODO @Jan200101 recreate PR once this is merged
This reverts commit 99c5c86.