Fix manual hooks storing their name badly #774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ASpoonPlaysGames
added
needs testing
|
Broken log: (line 924) |
EladNLG
approved these changes
Aug 25, 2024
There was a problem hiding this comment.
Looked at everything, changes are obvious, and make sense.
Have not tested, but i think @GeckoEidechse did
GeckoEidechse
approved these changes
Aug 25, 2024
There was a problem hiding this comment.
Cannot reproduce in testing with the CI builds but I trust @ASpoonPlaysGames to have done the testing with the isolated change and so I'm signing it off together with the review by @EladNLG.
RoyalBlue1
approved these changes
Aug 25, 2024
ASpoonPlaysGames
added a commit
to ASpoonPlaysGames/NorthstarLauncher
that referenced
this pull request
Aug 26, 2024
Fix manual hooks storing their name wrong and move to just using std::string since it's much more convenient and this isn't C
ASpoonPlaysGames
added a commit
to ASpoonPlaysGames/NorthstarLauncher
that referenced
this pull request
Aug 26, 2024
Fix manual hooks storing their name wrong and move to just using std::string since it's much more convenient and this isn't C
GeckoEidechse
removed
needs testing
wolf109909
pushed a commit
to R2NorthstarCN/NorthstarLauncher
that referenced
this pull request
Sep 8, 2024
Fix manual hooks storing their name wrong and move to just using std::string since it's much more convenient and this isn't C
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They weren't storing the null terminator since
strlendoesn't include it. This meant that anyManualHooks were logging their name blindly and just reading random memory until they hit a null terminator.I also moved over to just using
std::stringinstead of doing manual allocations etc. since we are doing C++ here we have these tools why not use them.Testing:
OnCommandSubmittedHookdoesn't log it's own name properly when enabled (there are also others)