Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove uses of Autohook from latencyflex.cpp #789

Merged

Conversation

ASpoonPlaysGames
Copy link
Contributor

Code review:

  • The original function is prefixed with o_p so any times where the old AUTOHOOK was calling the original function it should now be calling that instead.
  • The hook function is prefixed with h_ so any times where we would be wanting to call the hooked function from other functions should now be calling that instead

Testing:

  • Check logs to make sure that all of the changed hooks are being created properly
  • Make sure that the convar r_latencyflex works as usual

@ASpoonPlaysGames ASpoonPlaysGames added needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code labels Aug 27, 2024
@GeckoEidechse
Copy link
Member

r_latencyflex doesn't show up for me on main. I assume it only does when actually running LatencyFlex? Honestly this is gonna be a pain to test so if @F1F7Y says the code is fine, I'd propose to merge and immediately release afterwards to test in prod instead.

@F1F7Y
Copy link
Member

F1F7Y commented Aug 29, 2024

r_latencyflex should always show up on client. I'll look into it when I get home ( in ~4h )

@F1F7Y
Copy link
Member

F1F7Y commented Aug 30, 2024

I forgor 💀

Copy link
Member

@F1F7Y F1F7Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good 🐟

@F1F7Y
Copy link
Member

F1F7Y commented Aug 30, 2024

not seeing r_latencyflex means the dll load callback just isnt getting called or its returning here

spdlog::info("Unable to load LatencyFleX library, LatencyFleX disabled.");
return;
which also logs so would be cool if you could check logs @GeckoEidechse if you have time.

Reading the check the convar only exists when either latencyflex_layer.dll or latencyflex_wine.dll exist.

Copy link
Member

@GeckoEidechse GeckoEidechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The line @F1F7Y mentioned still shows up using this PR so I guess it works. Unfortunately I don't have a LatencyFlex setup to test this further so this must do ig.

[2024-08-31] [11:32:02] [NORTHSTAR] [info] Unable to load LatencyFleX library, LatencyFleX disabled.

@GeckoEidechse GeckoEidechse removed needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code labels Aug 31, 2024
@GeckoEidechse GeckoEidechse merged commit 4d609a8 into R2Northstar:main Aug 31, 2024
4 checks passed
@ASpoonPlaysGames ASpoonPlaysGames deleted the autohook/latencyflex.cpp branch September 5, 2024 12:51
wolf109909 pushed a commit to R2NorthstarCN/NorthstarLauncher that referenced this pull request Sep 8, 2024
Removes AUTOHOOK macro from `latencyflex.cpp`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants