Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modlist Hotfixes #510

Merged
merged 3 commits into from
Oct 8, 2022
Merged

Modlist Hotfixes #510

merged 3 commits into from
Oct 8, 2022

Conversation

uniboi
Copy link
Contributor

@uniboi uniboi commented Sep 22, 2022

Fix some bugs with the new modlist:

  • scrolling now updates the slider length accurately if filters apply
  • scrolling now sets the scroll offset correctly to not create whitespace that may break the list
  • guard against some bad indexes that may happen from other bugs

you can recreate a bug that's caused by not correctly updating some stuff when enabling a bunch of mods (more than 15!), then filtering by enabled mods only, scrolling to the bottom, disabling some mods and scrolling again. That would throw an UI error.

Copy link
Member

@GeckoEidechse GeckoEidechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compared to the version currently on main, this script errors, when having less mods installed than fills the list and the trying to scroll with mouse wheel.

@GeckoEidechse GeckoEidechse added the needs testing Changes from the PR still need to be tested label Oct 8, 2022
Copy link
Member

@GeckoEidechse GeckoEidechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No longer breaks like it did before in testing.

@GeckoEidechse GeckoEidechse merged commit 1804b78 into R2Northstar:main Oct 8, 2022
@uniboi uniboi deleted the modlist-hotfixes branch October 8, 2022 10:31
JMM889901 pushed a commit to JMM889901/NorthstarMods that referenced this pull request Aug 12, 2024
* fix mod list overflow

* better offset validation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs testing Changes from the PR still need to be tested
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants