-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use structs in the server browser #623
Merged
RoyalBlue1
merged 7 commits into
R2Northstar:main
from
uniboi:server-browser-struct-test
Apr 27, 2023
Merged
Use structs in the server browser #623
RoyalBlue1
merged 7 commits into
R2Northstar:main
from
uniboi:server-browser-struct-test
Apr 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quick skim and oh damn, this looks so much nicer than what we have rn 👀 |
F1F7Y
approved these changes
Apr 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, works in testing
Northstar.Client/mod/scripts/vscripts/ui/menu_ns_serverbrowser.nut
Outdated
Show resolved
Hide resolved
Northstar.Client/mod/scripts/vscripts/ui/menu_ns_serverbrowser.nut
Outdated
Show resolved
Hide resolved
uniboi
added
needs testing
Changes from the PR still need to be tested
depends on another PR
Blocked until the PR it depends on is merged
labels
Apr 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
depends on another PR
Blocked until the PR it depends on is merged
needs testing
Changes from the PR still need to be tested
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implements the changes from R2Northstar/NorthstarLauncher#453 and adds callbacks when connecting to a server via UI to allow mods to track which server has been joined
Registers a new callback; throws an error if the same callback is being registered twice
Remove a callback
Triggers all connection callbacks