Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use structs in the server browser #623

Merged
merged 7 commits into from
Apr 27, 2023

Conversation

uniboi
Copy link
Contributor

@uniboi uniboi commented Apr 22, 2023

implements the changes from R2Northstar/NorthstarLauncher#453 and adds callbacks when connecting to a server via UI to allow mods to track which server has been joined

void function AddConnectToServerCallback( void functionref( ServerInfo ) callback )

Registers a new callback; throws an error if the same callback is being registered twice

void function RemoveConnectToServerCallback( void functionref( ServerInfo ) callback )

Remove a callback

void function TriggerConnectToServerCallbacks()

Triggers all connection callbacks

@GeckoEidechse
Copy link
Member

Quick skim and oh damn, this looks so much nicer than what we have rn 👀

Copy link
Member

@F1F7Y F1F7Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, works in testing

@uniboi uniboi added needs testing Changes from the PR still need to be tested depends on another PR Blocked until the PR it depends on is merged labels Apr 26, 2023
@RoyalBlue1 RoyalBlue1 merged commit 2d6ca83 into R2Northstar:main Apr 27, 2023
@uniboi uniboi deleted the server-browser-struct-test branch April 27, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
depends on another PR Blocked until the PR it depends on is merged needs testing Changes from the PR still need to be tested
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants