Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix serverbrowser filtering by gamemode #639

Merged
merged 1 commit into from
May 4, 2023
Merged

Fix serverbrowser filtering by gamemode #639

merged 1 commit into from
May 4, 2023

Conversation

ASpoonPlaysGames
Copy link
Contributor

Closes #638

@ASpoonPlaysGames ASpoonPlaysGames changed the title FIx serverbrowser filtering by gamemode Fix serverbrowser filtering by gamemode May 3, 2023
@ASpoonPlaysGames
Copy link
Contributor Author

Requesting review (and hopefully merge) from fifty because I believe gecko is rather busy this week

uniboi
uniboi approved these changes May 3, 2023
View reviewed changes
Copy link
Contributor

@uniboi uniboi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep code looks good. it's just an oversight from the structs

F1F7Y
F1F7Y approved these changes May 3, 2023
View reviewed changes
Copy link
Member

@F1F7Y F1F7Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comparing the diffs this should fix the issue, but cant test rn :)

@F1F7Y
Copy link
Member

F1F7Y commented May 3, 2023

(and hopefully merge)

Even if i were to merge it rn gecko is the one making releases and deciding what goes into them

GeckoEidechse
GeckoEidechse approved these changes May 4, 2023
View reviewed changes
Copy link
Member

@GeckoEidechse GeckoEidechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed working in testing

@GeckoEidechse GeckoEidechse merged commit 9181e52 into R2Northstar:main May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@F1F7Y F1F7Y F1F7Y approved these changes

@uniboi uniboi uniboi approved these changes

@GeckoEidechse GeckoEidechse GeckoEidechse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Northstar Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Filtering server browser by gamemode is broken
4 participants
@ASpoonPlaysGames @F1F7Y @GeckoEidechse @uniboi