Fix attrition freezing and killing servers sometimes #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Add the "needs testing" and "needs code review" tags, I DARE YOU |
pg9182
approved these changes
May 11, 2023
Northstar.CustomServers/mod/scripts/vscripts/gamemodes/_gamemode_aitdm.nut
Show resolved
Hide resolved
|
Note: The buggy PR is in NS 1.13.2+. |
GeckoEidechse
approved these changes
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More specifically, it happened when all enemy NPCs were dead and an NPC squad tried to find somewhere to attack. They wouldn't find any valid places to attack, so naturally you just
continuein the loop and try again next time... except you forgot to wait any amount of time before trying again, so it's just going to try again in that same frame, forever.Regression caused by #626 and rly should've been caught in testing or code review tbh
Closes R2Northstar/Northstar#483