Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix script compile error for progression in SP #714

Merged
merged 2 commits into from
Sep 18, 2023

Conversation

ASpoonPlaysGames
Copy link
Contributor

@ASpoonPlaysGames ASpoonPlaysGames commented Sep 18, 2023

man supporting CLIENT, SERVER, UI, MP, and SP in one file sucks.

@GeckoEidechse GeckoEidechse changed the title fix progression in SP Fix script compile error for progression in SP Sep 18, 2023
Copy link
Member

@GeckoEidechse GeckoEidechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed working in testing.

I don't feel confident enough to do code review here but merging anyway as I trust @ASpoonPlaysGames in doing the right thing and we need the hot patch now :P

@GeckoEidechse GeckoEidechse merged commit 6bfd52b into R2Northstar:main Sep 18, 2023
3 checks passed
@ASpoonPlaysGames ASpoonPlaysGames added needs testing Changes from the PR still need to be tested waiting on changes by author Waiting on PR author to implement the suggested changes and removed needs testing Changes from the PR still need to be tested waiting on changes by author Waiting on PR author to implement the suggested changes labels Sep 18, 2023
@GeckoEidechse GeckoEidechse added the progression Changes related to progression system label Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
progression Changes related to progression system
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants