Expose extra optional arg in UpdatePlayerStat function
#742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a1ea16b.
Github actions having a moment, so I'm making a random whitespace change to trigger it again
Zanieon
added
the
needs code review
GeckoEidechse
changed the title
UpdatePlayerStat functionUpdatePlayerStat function
GeckoEidechse
approved these changes
Oct 12, 2023
There was a problem hiding this comment.
Trivial change as it just adds an optional function arg. Shouldn't need any testing.
Gonna let @ASpoonPlaysGames sign this off nevertheless as it touches progression related logic ^^
GeckoEidechse
added
the
almost ready to merge
ASpoonPlaysGames
requested changes
Oct 12, 2023
Co-authored-by: Jack <66967891+ASpoonPlaysGames@users.noreply.github.com>
ASpoonPlaysGames
approved these changes
Oct 12, 2023
ASpoonPlaysGames
added
READY TO MERGE
|
Merging based on reviews. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposes the previously hidden string argument in the
UpdatePlayerStatfunction, that is needed to track some things more easily when hooking stats from places that needs to be manually made since it's not doable via callbacks.Currently some of the FD stats requires a Titan Ref to be specified in order to register, and that third string argument is where it goes.
Weapon assists also have challenges which does not track because they also need that extra arg for the Weapon Ref, since that needs to be hooked from another script.