-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Arc Cannon not hurting npc_gunship
and npc_pilot_elite
#863
Fix Arc Cannon not hurting npc_gunship
and npc_pilot_elite
#863
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with this, @NachosChipeados might wanna do another PR to also include npc_gunship
as they are also missing from that array, and they are still a possibility for modding in the game.
Question: does |
It works becase what you need to care in this is the BaseClass of the aisetting definition, not the name of the setting itself, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simple additions, i see that you decided to include my suggestion, so all good for me.
17bb90b
to
8878307
Compare
npc_gunship
and npc_pilot_elite
Given the simple nature of the change I'm fine with merging it without any further testing as it can easily be reverted should something turn out to not work out as intended ^^ |
Fixes #842 . I only NOW realized i could just pr it directly lol