Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Arc Cannon not hurting npc_gunship and npc_pilot_elite #863

Merged
merged 5 commits into from
Sep 4, 2024

Conversation

NachosChipeados
Copy link
Contributor

Fixes #842 . I only NOW realized i could just pr it directly lol

@GeckoEidechse
Copy link
Member

Copy link
Contributor

@Zanieon Zanieon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this, @NachosChipeados might wanna do another PR to also include npc_gunship as they are also missing from that array, and they are still a possibility for modding in the game.

@NachosChipeados NachosChipeados changed the title Fix Arc Cannon not hurting npc_pilot_elite Fix Arc Cannon not hurting two npc types Sep 3, 2024
@NachosChipeados
Copy link
Contributor Author

Question: does npc_pilot_elite_assassin work? Its not derived from npc_pilot_elite or npc_soldier so theoretically the Arc Cannon wouldn't be able to hit them, but i can't get them to spawn so i can't test it

@Zanieon
Copy link
Contributor

Zanieon commented Sep 3, 2024

Question: does npc_pilot_elite_assassin work? Its not derived from npc_pilot_elite or npc_soldier so theoretically the Arc Cannon wouldn't be able to hit them, but i can't get them to spawn so i can't test it

It works becase what you need to care in this is the BaseClass of the aisetting definition, not the name of the setting itself, npc_pilot_elite_assassin still uses npc_pilot_elite as BaseClass, so it will be counted.

Copy link
Contributor

@Zanieon Zanieon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple additions, i see that you decided to include my suggestion, so all good for me.

@GeckoEidechse GeckoEidechse changed the title Fix Arc Cannon not hurting two npc types Fix Arc Cannon not hurting npc_gunship and npc_pilot_elite Sep 4, 2024
@GeckoEidechse
Copy link
Member

Given the simple nature of the change I'm fine with merging it without any further testing as it can easily be reverted should something turn out to not work out as intended ^^

@GeckoEidechse GeckoEidechse merged commit 16c1f6d into R2Northstar:main Sep 4, 2024
3 checks passed
@NachosChipeados NachosChipeados deleted the arc-npc_pilot_elite branch September 4, 2024 12:35
@GeckoEidechse GeckoEidechse removed their assignment Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Arc Cannon can't damage npc_pilot_elite
3 participants