Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete _spawnpoints.gnut #890

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Delete _spawnpoints.gnut #890

merged 1 commit into from
Oct 10, 2024

Conversation

Zanieon
Copy link
Contributor

@Zanieon Zanieon commented Oct 6, 2024

Unused file, not loaded by Northstar.

@github-actions github-actions bot added needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code labels Oct 6, 2024
GeckoEidechse
GeckoEidechse approved these changes Oct 10, 2024
View reviewed changes
Copy link
Member

@GeckoEidechse GeckoEidechse left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless there's some weird undefined behaviour that I'm not aware of, this should be a no-brainer to merge lol as it simply deletes an empty file.

@GeckoEidechse GeckoEidechse merged commit e616cb1 into R2Northstar:main Oct 10, 2024
5 checks passed
@Zanieon Zanieon deleted the remove_empty_file branch October 10, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeckoEidechse GeckoEidechse GeckoEidechse approved these changes

Assignees
No one assigned
Labels
needs code review Changes from PR still need to be reviewed in code needs testing Changes from the PR still need to be tested
Projects
Northstar Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zanieon @GeckoEidechse