VC's did/will (dis)appear #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| private func triggerForSelector(selector: Selector) -> Signal<(), NoError> { | ||
| return self | ||
| .rac_signalForSelector(selector) | ||
| .rex_toSignal() |
There was a problem hiding this comment.
Use rex_toTriggerSignal() from #99 ?
|
It might be nice to add the appear methods while you're at it. It seems natural to want both if you want one. |
| return triggerForSelector(#selector(UIViewController.viewWillAppear(_:))) | ||
| } | ||
|
|
||
| private func triggerForSelector(selector: Selector) -> Signal<(), NoError> { |
There was a problem hiding this comment.
Should triggerForSelector be inside extension of NSObject (or UIResponder) ?
There was a problem hiding this comment.
@335g Looking at UIResponder documentation, I don't think so. I might be missing something.
There was a problem hiding this comment.
Now, It might be good in this 👍
|
Awesome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.