Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added UIKit extensions #54

Merged
merged 5 commits into from
Oct 21, 2015
Merged

Added UIKit extensions #54

merged 5 commits into from
Oct 21, 2015

Conversation

avalanched
Copy link
Contributor

No description provided.

@neilpa neilpa self-assigned this Oct 21, 2015
@neilpa
Copy link
Member

neilpa commented Oct 21, 2015

These are great! Thanks for the PR.

I can cut a new release with these if you'd like. Otherwise I was waiting for the RAC 4 alpha 2.

neilpa added a commit that referenced this pull request Oct 21, 2015
@neilpa neilpa merged commit 776de13 into RACCommunity:master Oct 21, 2015
@avalanched
Copy link
Contributor Author

waiting for alpha 2 is just fine for me. I will try to add some more the coming days.

@neilpa
Copy link
Member

neilpa commented Oct 21, 2015

I will try to add some more the coming days.

😄

@bjarkehs
Copy link
Contributor

Out of curiosity: How do the retain cycle tests work?
Nvm, I just realized it was all in the tearDown. 👍

@avalanched
Copy link
Contributor Author

@bjarkehs in the tearDown you check if the object is successfully deallocated, there was a retain cycle issue in a previous build when binding a property, this was fixed in #28

@bjarkehs
Copy link
Contributor

@avalanched Yeah, I edited my own comment a few seconds before your response. Had not expected anyone to respond this quickly. Anyway, thanks for the added properties 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants