Added UITextView text's producer #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| public var rex_textSignal: SignalProducer<String, NoError> { | ||
| return NSNotificationCenter.defaultCenter() | ||
| .rac_notifications(UITextViewTextDidChangeNotification, object: self) | ||
| .filterMap { notification in |
There was a problem hiding this comment.
Just a suggestion (not necessarily any better, depending on how you value code clarity etc), but might something like .filterMap { ($0 as? UITextView)?.text } be simpler?
There was a problem hiding this comment.
That is not equivalent. the $0 is a NSNotification. $0.object is a UITextView. I am ok with the change:
public var rex_textSignal: SignalProducer<String, NoError> {
return NSNotificationCenter.defaultCenter()
.rac_notifications(UITextViewTextDidChangeNotification, object: self)
.filterMap { ($0.object as? UITextView)?.text }
}
But then I would like to change the UITextField (for consistency sake). @neilpa what do you think?
There was a problem hiding this comment.
Sorry, yes — that was just me not paying enough attention.
($0.notification.object as? UITextView)?.text
There was a problem hiding this comment.
If you want to make that change and update UITextField I'm fine with that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.