Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to fix pause slot positions anim properly #20

Open
jnackmclain opened this issue Jun 4, 2024 · 1 comment
Open

How to fix pause slot positions anim properly #20

jnackmclain opened this issue Jun 4, 2024 · 1 comment

Comments

@jnackmclain
Copy link
Contributor

Linking a dx issue here as it was brought up there, and I cant fix it, but i figured out why
hmxmilohax/rock-band-3-deluxe#495
im no coder, but i looked in RndPropAnimHooks.c

rb3e checks if the anim frame is not 0, and if so, forces it to 2
which is correct BUT you must account for vocal players as well, as this will break certain circumstances
here is what we do in dx.
image

I have been banging my head on this issue but turns out its rb3e specifically.
and I cant fix it on my end as rb3e overwrites the anim frame
Hope this helps

@jnackmclain
Copy link
Contributor Author

for context, this macro is used here
so an int frame is the return value used in set_frame
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant