Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common Issues facing Datasets #57

Closed
bms63 opened this issue Feb 10, 2023 · 5 comments
Closed

Common Issues facing Datasets #57

bms63 opened this issue Feb 10, 2023 · 5 comments
Assignees
Labels

Comments

@bms63
Copy link
Collaborator

bms63 commented Feb 10, 2023

No description provided.

@bms63
Copy link
Collaborator Author

bms63 commented Feb 10, 2023

Collate common issues noticed in dataset compares, package issues, etc.

@kaz462
Copy link
Collaborator

kaz462 commented Feb 17, 2023

1. Package issue tracking

1.1 Package issues

  • haven::read_xpt()
    Some attributes are dropped after using haven::write_xpt() haven::read_xpt(), e.g., type, length.
    to do: further check

  • xportr::xportr_length()
    NA_character_ is considered as length 2 - issue resolved on Dec 14, 2022
    to do: to be incorporated in pilot3

1.2 Potential improvement

2. Knowledge sharing

Summary of similarities and differences between packages, to help user identify the best tool that suits the need.
Maybe this could go to Bayer SAS2R catalog in the future,

metatools vs xportr

  • metatools::set_variable_labels() vs xportr::xportr_label()

xportr vs haven

  • xportr::xportr_write() vs haven::write_xpt()

diffdf vs arsenal

  • diffdf::diffdf() vs arsenal::comparedf()

@laxamanaj
Copy link
Collaborator

Lets add this to wiki : https://github.com/RConsortium/submissions-pilot3-adam/wiki

in a new page.

@kaz462
Copy link
Collaborator

kaz462 commented Apr 14, 2023

  • haven::read_xpt()
    Some attributes are dropped after using haven::write_xpt() haven::read_xpt(), e.g., type, length.
    to do: further check

just found an issue has been posted for haven::read_sas/xpt
tidyverse/haven#718

@laxamanaj
Copy link
Collaborator

Thank you, @kaz462 for creating this issue and tracking common issues. I was able to add this as new page to our wiki, which is here : https://github.com/RConsortium/submissions-pilot3-adam/wiki/Common-Issues

For now I will go ahead and close this issue. If any further Common Issues come up, we can add them directly to this new Wiki page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants