Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark the identifier parameter of ConjunctiveGraph as deprecated #2407

Open
aucampia opened this issue May 24, 2023 · 1 comment
Open

Mark the identifier parameter of ConjunctiveGraph as deprecated #2407

aucampia opened this issue May 24, 2023 · 1 comment
Labels
breaking change This involves or proposes breaking RDFLib's public API. concept: RDF dataset Relates to the RDF datasets concept. core Relates to core functionality of RDFLib, i.e. `rdflib.{graph,store,term}`

Comments

@aucampia
Copy link
Member

ConjunctiveGraph's constructor allows specification of a custom identifier for the default graph with the identifier parameter.

I don't think there is a good reason to do this, the default graph should be the default graph, but I may be wrong. If there is a good reason I think it would be good to document it. If, however, there is no good reason to allow specifying a custom identifier for the default graph, then we should deprecate the identifier parameter by raising a deprecation warning when it is used.
@aucampia aucampia added the breaking change This involves or proposes breaking RDFLib's public API. label May 24, 2023
@aucampia
Copy link
Member Author

This issue becomes invalid if this other issue is addressed:

@aucampia aucampia added core Relates to core functionality of RDFLib, i.e. `rdflib.{graph,store,term}` concept: RDF dataset Relates to the RDF datasets concept. good first issue Good for newcomers and removed good first issue Good for newcomers labels May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change This involves or proposes breaking RDFLib's public API. concept: RDF dataset Relates to the RDF datasets concept. core Relates to core functionality of RDFLib, i.e. `rdflib.{graph,store,term}`
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aucampia