Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why SPARQLStore is not graph_aware? #399

Closed
bcogrel opened this issue Jun 10, 2014 · 4 comments
Closed

Why SPARQLStore is not graph_aware? #399

bcogrel opened this issue Jun 10, 2014 · 4 comments

Comments

@bcogrel
Copy link
Contributor

bcogrel commented Jun 10, 2014

SPARQLStore is by default context_aware but not (yet?) graph_aware:

>>> from rdflib import Dataset
>>> from rdflib.plugins.stores.sparqlstore import SPARQLStore

>>> store = SPARQLStore("http://localhost:3030/test/query") 
>>> graph = Dataset(store)
Exception: DataSet must be backed by a graph-aware store!

Should graph-awareness be enabled?

@uholzer
Copy link
Contributor

uholzer commented Jun 10, 2014

Actually, I was wondering the same thing. What is required for a store to be graph_aware?

I thought this was somewhere documented in rdflib/store.py. I guess implementing add_graph and remove_graph as well as setting graph_aware=True should do the trick.

@bcogrel
Copy link
Contributor Author

bcogrel commented Jun 12, 2014

Good, thanks for the guideline. I will submit two patches soon.

@gromgull
Copy link
Member

No reason :) The SPARQLStore predates the concept of graph-aware stores, and noone has updated it yet!

@bcogrel
Copy link
Contributor Author

bcogrel commented Jul 10, 2014

Patches merged

@bcogrel bcogrel closed this as completed Jul 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants