Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

closednamespace inheritance fix on 5.0.0-dev #596

Closed
joernhees opened this issue Feb 15, 2016 · 4 comments · Fixed by #1213
Closed

closednamespace inheritance fix on 5.0.0-dev #596

joernhees opened this issue Feb 15, 2016 · 4 comments · Fixed by #1213

Comments

@joernhees
Copy link
Member

the fix for #542 in #551 was backwards incompatible and thus not fit for the patch release 4.2.2 and reverted in #595

this issue is a reminder to either replay bccc761 and ae1f639 on top of 5.0.0-dev or maybe drop the unicode base-class for Namespace altogether...

@gromgull any preference?

@joernhees joernhees added this to the rdflib 5.0.0 milestone Feb 15, 2016
@gromgull
Copy link
Member

I would drop unicode for namespace, I cannot really see any use-cases why it is useful that it's a subclass at all?

Then let ClosedNamespace inherit from Namespace

@niklasl
Copy link
Member

niklasl commented Feb 15, 2016

👍 Totally agree.

@joernhees
Copy link
Member Author

please have a look at #597

@kernc
Copy link
Contributor

kernc commented Dec 16, 2020

I cannot really see any use-cases why it is useful that it's a subclass at all?

How does one filter for "properties" from DCTERMS namespace if not by:

for p, o in g.predicate_objects(s):
    if p.startswith(DCTERMS):
        ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants