Issue 2283: Add type-review support for SPARQL query results from Graph.query #2320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch is known to be an incomplete implementation. Running `mypy test/test_typing.py` before this patch raised 0 type errors. After just adding the two new tests, 3. After starting the subclasses of Query, 30. References: * RDFLib#2283 Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
|
PRs to V6 is closed until further notice. See this for more details: |
We will be open for PRs again once this is resolved: |
|
@ajnelson-nist do you want to continue with this PR not that v7.x is out and we are merging PRs again? |
Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
Potentially, adding an assert() addresses the subclass type review, per `@classmethod` docs: > ... If a class method is called for a derived class, the derived class > object is passed as the implied first argument. This patch also reverts the first-draft change to `Graph.query`. References: * https://docs.python.org/3/library/functions.html#classmethod * RDFLib#2283 (comment) Suggested-by: Iwan Aucamp <aucampia@gmail.com> Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
References: * RDFLib#2283 Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
|
I've given this a nudge. Following @aucampia 's suggestion looks promising, but it runs into a circular import issue bringing in The class |
|
I'm pausing working on this for the time being. Suggestions are welcome. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Checklist
the same change.
SELECTandCONSTRUCTqueriesDESCRIBEandASKqueries./examplesfor new features.CHANGELOG.md).so maintainers can fix minor issues and keep your PR up to date.