Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "skip round-trip test, unfixable until 5.0" #702

Closed
wants to merge 2 commits into from
Closed

Revert "skip round-trip test, unfixable until 5.0" #702

wants to merge 2 commits into from

Conversation

joernhees
Copy link
Member

This reverts commit 7bec219, see #431 and #699

depends on #436

This should remind us to not forget this in 5.0.0

@joernhees joernhees added bug Something isn't working serialization Related to serialization. testing labels Jan 26, 2017
@joernhees joernhees added this to the rdflib 5.0.0 milestone Jan 26, 2017
@nicholascar nicholascar modified the milestones: rdflib 5.0.0, rdflib 6.0.0 Apr 3, 2020
@nicholascar
Copy link
Member

This wasn't merged into 5.0.0 as it's potentially still an issue as of July 2020. The test still fails on 5.0.0.

@nicholascar
Copy link
Member

The test that this PR is aiming to re-enable is wrong.

Each time the ConjunctiveGraph is re-fed the default and Blank Node-identified graphs in the loop it correctly assigns new BNs to them. So this means that indeed the count of thing_b etc. will be > 1.

So, I think the test should be changed as the behavior is correct and, if so, this PR can be merged with the updated test.

@ghost ghost added the id-as-cntxt tracking related issues label Feb 12, 2022
@ghost ghost added the 7.0 Changes planned for version 7 label Jun 8, 2022
@aucampia aucampia added the marked for closing The issue or PR will be closed soon if no further feedback is provided. label Aug 19, 2022
@aucampia
Copy link
Member

I'm going to close this PR after 2022-08-22 as I don't think it is relevant anymore:

  • We are using xfails now, and any test that has xfail marker that passes will be reported as xpass.
  • This PR still references nosetest which we no longer use.

@aucampia aucampia closed this Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
7.0 Changes planned for version 7 bug Something isn't working id-as-cntxt tracking related issues marked for closing The issue or PR will be closed soon if no further feedback is provided. serialization Related to serialization. testing
Projects
None yet
Milestone
7.0.0 release
Development

Successfully merging this pull request may close these issues.
4 participants
@joernhees @nicholascar @aucampia @white-gecko