-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add testing for query caching #1
Comments
Make sure |
Even if the session is hashable and a singleton I am not sure it makes sense to include it in the cache fingerprint. The response body should be independent of session unless the API does weird things I think? |
Should this really be closed? |
I guess you are right. Any suggestions how to solve this? I would like to keep |
We could run the test with actual API calls, CI can handle that. Or are you asking re: my session comment above? |
Test could be improved using stored info in cach_info. |
To avoid multiple execution of the same API queries, the Converter class has cache implemented. This needs to be properly tested.
The text was updated successfully, but these errors were encountered: