Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow travellers to be square #31

Open
davewhiteland opened this issue Apr 28, 2020 · 0 comments
Open

allow travellers to be square #31

davewhiteland opened this issue Apr 28, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@davewhiteland
Copy link
Collaborator

davewhiteland commented Apr 28, 2020

It might be handy to have non-round travellers (so they look distinct from vertices, especially when carrying payloads).

This is related to #27 but would be a little easier (so maybe do this one first?): we already have a type which is currently spot or sprite. Seems like that could be

  • circle (synonym for spot), square, sprite

...and unlike vertices there's no complication about edges/arrowheads joining neatly.

I thought I had a specific use case here, animating a stack for a push-down automaton, and pushing round travellers (which is how I've done it in other graphs where I was putting the vertex on the stack) was going to be confusing because they would look like vertices moving... but now I don't think it's relevant because I'll probably implement them off-graph (using Pixi directly). It's almost as if having a separate stack (outside the graph and its nodes) is a whole new needed feature. Hmm.

square has the advantage of not needing any more specification config than we already have (because we could, um, repurpose radius... too dirty/lazy? Maybe height and width since we can anticipate rectangles (and PIXI supports rounded rect too).

@davewhiteland davewhiteland added the enhancement New feature or request label Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant