cpu: Add PIC32MZ support #6066

neiljay · 2016-11-07T15:17:45Z

~~This PR is dependant on #6060~~ - merged

Add support for PIC32 MZ devices which use a MIPS M5150 core.

This PR adds basic support for Microchip PIC32MZ devices, including
bootstrapping the device, the build system produces a hex image loadable via
MPLAB-IPE. It has been tested on a Digilent Wifire board.

NOTE: This port requires the use of the GCC based MIPS Codescape SDK toolchain
available here:

https://community.imgtec.com/developers/mips/tools/codescape-mips-sdk/download-codescape-mips-sdk-essentials/

You cannot use Microchip's MPLAB / Harmony tools to build this port.

The port has been tested with the following examples:
hello-world
ipc_pingpong
timer_periodic_wakeup
riot_and_cpp

Note this is a re-work of #5885 with review comments addressed but now broken down into 3 separate PR's of which this is the second.

OlegHahm · 2016-11-21T17:44:16Z

I was able to build and flash the ipc_pingpong (at least mdb is saying:

Programming target...
Program succeeded.

but I couldn't get any output.

OlegHahm · 2016-11-21T17:45:47Z

Do I assume correctly that UART0 is configured over the mini-USB port?

neiljay · 2016-11-21T17:55:48Z

Its UART4 on the pic device, but yes the MINI USB header is the one you
want, 9600 8N1.

If you want to power the board off that USB cable you need to set the
'VUSelect' Jumper to 'UART'.

you might need to press enter a couple of times in your console to wake
up the USB<->UART converter.

Neill

On 11/21/16 17:45, Oleg Hahm wrote:

Do I assume correctly that UART0 is configured over the mini-USB port?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#6066 (comment), or
mute the thread
https://github.com/notifications/unsubscribe-auth/AUEU6pKgstiJwJiaPbTIFzZar9stpHe3ks5rAdjPgaJpZM4KrU6C.

OlegHahm · 2016-11-21T17:57:49Z

Ah, true. Forgot about the 9600 baud... Now it is working! 👍

neiljay · 2016-11-21T17:58:43Z

Sweet!

On 11/21/16 17:57, Oleg Hahm wrote:

Ah, true. Forgot about the 9600 baud... Now it is working! 👍

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#6066 (comment), or
mute the thread
https://github.com/notifications/unsubscribe-auth/AUEU6i_uF7-N0n7FaH3gWjyELMNS1j5oks5rAduhgaJpZM4KrU6C.

neiljay · 2017-02-13T16:07:02Z

Hi all,

Why are we running cppcheck on .s and .S files ?

I get this error:
cpu/mips_pic32_common/reset_mod.S:84: error (syntaxError): syntax error
from this line:
beqz s1, init_resources # Branch if this is NOT an NMI exception.
The code assembles fine, I tried an unnamed label '1f' but it didn't like that either...

It looks like this check fails on other (in tree) asm file also (testing in my local docker image):

cpu/lpc2387/asmfunc.s:0: error (syntaxError): syntax error

Hopefully this is now close to a point where we can merge it, The PIC32 ports should be of more interest as the targets are readily available and cheap. @OlegHahm Can you try this on your board.

I ran the unittest suite and that all passed:

main(): This is RIOT! (Version: 2017.04-devel-152-g204aa-a2f4afe6403a-pr/add_mips-pic32_mz)
........................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................
OK (712 tests)

neiljay · 2017-02-14T10:11:09Z

So cppcheck was failing on the asm style comments (in an asm file) WTF!!

jnohlgard · 2017-03-01T15:10:28Z

I'm seeing errors with objcopy at the end:

   text	   data	    bss	    dec	    hex	filename
  78616	   2424	   6012	  87052	  1540c	/home/jgn/work/src/riot/examples/default/bin/pic32-clicker/default.elf
objcopy: /home/jgn/work/src/riot/examples/default/bin/pic32-clicker/default.hex: address 0xffffffff1d000000 out of range for Intel Hex file
objcopy:/home/jgn/work/src/riot/examples/default/bin/pic32-clicker/default.hex: Bad value
objcopy: --change-section-lma .gcc_except_table+0xffffffff80000000 never used
make: *** [/home/jgn/work/src/riot/examples/default/../../Makefile.include:278: all] Error 1

Both pic32-wifire and pic32-clicker.

GNU objcopy (Gentoo 2.27 p1.0) 2.27

neiljay · 2017-03-13T10:15:02Z

@gebart Are you happy for me to squash this now so we can get this merged ?

jnohlgard · 2017-03-13T15:14:38Z

boards/pic32-wifire/Makefile.features

@@ -0,0 +1,9 @@
+# Put defined MCU peripherals here (in alphabetical order)
+FEATURES_PROVIDED += periph_timer
+FEATURES_PROVIDED += periph_uart


Why is periph_uart in FEATURES_PROVIDED if there is no UART available?
according to comment at https://github.com/RIOT-OS/RIOT/pull/6066/files#diff-8790a8833e3d374cd14889b9f0e69a2cR18

Uart Tx is implemented but not the full UART API yet.

I tweaked the comment when squashing see e2d7d36

neiljay · 2017-03-14T09:16:47Z

@gebart @OlegHahm @haukepetersen Can we finally get this ACK'd and merged ? :-)

jnohlgard · 2017-03-14T13:04:53Z

I don't have any of the boards to test it. I'm fine with the change as long as Murdock is fine.

neiljay · 2017-03-14T13:43:13Z

@gebart Cheers, can you ACK your change-request then. @OlegHahm has a board we donated.

jnohlgard

Clearing my request for comments since my comments were addressed. I have not reviewed the code or tested this on an actual board though. Leaving the formal ACK to @OlegHahm and colleagues.

neiljay · 2017-03-16T09:22:21Z

Please can someone merge this @OlegHahm @haukepetersen @miri64 @kaspar030 :-)

kYc0o · 2017-03-17T13:37:56Z

This code is very similar to #6092, so I'll have more or less the same comments. I'd like to have the comments addressed before merging this one too...

neiljay · 2017-03-21T15:49:07Z

Can some one re-run the CI Please, I don't believe the error.

kaspar030 · 2017-03-21T15:51:20Z

Can some one re-run the CI Please, I don't believe the error.

Murdock (not Murdock2) is our current last-word, so this PR basically passed CI.

neiljay · 2017-03-21T15:53:02Z

Cheers, Can we get this merged at last ?

kaspar030 · 2017-03-21T15:56:13Z

boards/pic32-wifire/pic32_config_settings.c

+
+
+/*
+ * Without a reference to this function from elsewhere LD throws the whole


Probably has to do with missing '--whole-archive'. Could you please check if #5757 removes the need for this?

(well, let's not delay the PR because of this. can be checked at a later time.)

Hi,

Yes that has helped cheers, when #5757 gets merged I'll happily remove this.

Neil

Note this is only supported in unvectored mode currently.

specific support for the pic32mz2046efg100 is added along with code common to all pic32 devices and all pic32mz devices.

This board features a pic32mz2048efg100 PIC32 device with a MIPS core.

Extened the temporary workaround for mips boards to all mips boards until pr#6639 is merged.

neiljay · 2017-03-29T09:48:11Z

Now squashed some more, Please Please Please can we finally get this merged.....

haukepetersen

I think there are still some things that can substantially be simplified und unified, but this can be done later -> so ACK

haukepetersen · 2017-03-29T10:53:43Z

Murdock is happy, and we got two ACKs -> lets go

@neiljay thanks a lot for all the efforts and your patience!

neiljay · 2017-03-29T11:29:55Z

Thanks everyone!!
Now for pic32mx...

neiljay assigned haukepetersen Nov 7, 2016

neiljay added this to the Release 2017.01 milestone Nov 7, 2016

neiljay added Platform: MIPS Platform: This PR/issue effects MIPS-based platforms Type: new feature The issue requests / The PR implemements a new feature for RIOT Impact: major The PR changes a significant part of the code base. It should be reviewed carefully labels Nov 7, 2016

neiljay mentioned this pull request Nov 9, 2016

cpu: Add PIC32MX Support #6092

Merged

PeterKietzmann modified the milestones: Release 2017.01, Release 2017.04 Jan 26, 2017

neiljay force-pushed the pr/add_mips-pic32_mz branch 5 times, most recently from 4003290 to d273ecd Compare February 13, 2017 15:13

neiljay force-pushed the pr/add_mips-pic32_mz branch from fa24898 to 4413a76 Compare February 15, 2017 14:42

neiljay mentioned this pull request Feb 15, 2017

mips: Build system is not aligned with other platforms #6588

Closed

4 tasks

neiljay mentioned this pull request Feb 24, 2017

cpu/mips: Integrate better with RIOT newlib layer #6639

Closed

jnohlgard removed the State: waiting for other PR State: The PR requires another PR to be merged first label Mar 1, 2017

neiljay force-pushed the pr/add_mips-pic32_mz branch 2 times, most recently from f9d717f to 0075137 Compare March 10, 2017 16:04

jnohlgard reviewed Mar 13, 2017

View reviewed changes

neiljay force-pushed the pr/add_mips-pic32_mz branch from 27ed5fc to e2d7d36 Compare March 13, 2017 15:42

jnohlgard added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Mar 14, 2017

jnohlgard approved these changes Mar 14, 2017

View reviewed changes

neiljay force-pushed the pr/add_mips-pic32_mz branch from d70b7ff to d3a0c76 Compare March 21, 2017 14:50

kaspar030 reviewed Mar 21, 2017

View reviewed changes

Neil Jones added 2 commits March 24, 2017 13:44

cpu: mips: Add EIC interrupt mode support.

1838ca5

Note this is only supported in unvectored mode currently.

cpu: mips-pic32mz: Add support for PIC32MZ devices

241087f

specific support for the pic32mz2046efg100 is added along with code common to all pic32 devices and all pic32mz devices.

neiljay force-pushed the pr/add_mips-pic32_mz branch from 4cd9789 to 489e404 Compare March 24, 2017 13:45

Neil Jones added 4 commits March 28, 2017 16:25

boards: pic32-wifire: Add support for the Digilent WiFire board.

c4d28cb

This board features a pic32mz2048efg100 PIC32 device with a MIPS core.

sys: Extend MIPS temporary work around to all mips targets.

becfd63

Extened the temporary workaround for mips boards to all mips boards until pr#6639 is merged.

examples: gnrc_border_router: Blacklist all mips boards.

1113b58

examples: javascript: Blacklist pic32-wifire

0bafa33

neiljay force-pushed the pr/add_mips-pic32_mz branch from 7666577 to 0bafa33 Compare March 28, 2017 15:26

haukepetersen approved these changes Mar 29, 2017

View reviewed changes

haukepetersen merged commit 76bae4b into RIOT-OS:master Mar 29, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

cpu: Add PIC32MZ support #6066

cpu: Add PIC32MZ support #6066

neiljay commented Nov 7, 2016 •

edited by jnohlgard

Loading

OlegHahm commented Nov 21, 2016

OlegHahm commented Nov 21, 2016

neiljay commented Nov 21, 2016

OlegHahm commented Nov 21, 2016

neiljay commented Nov 21, 2016

neiljay commented Feb 13, 2017

neiljay commented Feb 14, 2017

jnohlgard commented Mar 1, 2017

neiljay commented Mar 13, 2017

jnohlgard Mar 13, 2017

neiljay Mar 13, 2017

neiljay Mar 13, 2017

neiljay commented Mar 14, 2017

jnohlgard commented Mar 14, 2017

neiljay commented Mar 14, 2017

jnohlgard left a comment

neiljay commented Mar 16, 2017

kYc0o commented Mar 17, 2017

neiljay commented Mar 21, 2017

kaspar030 commented Mar 21, 2017

neiljay commented Mar 21, 2017

kaspar030 Mar 21, 2017

kaspar030 Mar 21, 2017

neiljay Mar 21, 2017

neiljay commented Mar 29, 2017

haukepetersen left a comment

haukepetersen commented Mar 29, 2017

neiljay commented Mar 29, 2017



		/*
		* Without a reference to this function from elsewhere LD throws the whole

cpu: Add PIC32MZ support #6066

cpu: Add PIC32MZ support #6066

Conversation

neiljay commented Nov 7, 2016 • edited by jnohlgard Loading

OlegHahm commented Nov 21, 2016

OlegHahm commented Nov 21, 2016

neiljay commented Nov 21, 2016

OlegHahm commented Nov 21, 2016

neiljay commented Nov 21, 2016

neiljay commented Feb 13, 2017

neiljay commented Feb 14, 2017

jnohlgard commented Mar 1, 2017

neiljay commented Mar 13, 2017

jnohlgard Mar 13, 2017

Choose a reason for hiding this comment

neiljay Mar 13, 2017

Choose a reason for hiding this comment

neiljay Mar 13, 2017

Choose a reason for hiding this comment

neiljay commented Mar 14, 2017

jnohlgard commented Mar 14, 2017

neiljay commented Mar 14, 2017

jnohlgard left a comment

Choose a reason for hiding this comment

neiljay commented Mar 16, 2017

kYc0o commented Mar 17, 2017

neiljay commented Mar 21, 2017

kaspar030 commented Mar 21, 2017

neiljay commented Mar 21, 2017

kaspar030 Mar 21, 2017

Choose a reason for hiding this comment

kaspar030 Mar 21, 2017

Choose a reason for hiding this comment

neiljay Mar 21, 2017

Choose a reason for hiding this comment

neiljay commented Mar 29, 2017

haukepetersen left a comment

Choose a reason for hiding this comment

haukepetersen commented Mar 29, 2017

neiljay commented Mar 29, 2017

neiljay commented Nov 7, 2016 •

edited by jnohlgard

Loading