Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusion LINEAR/ANGULAR and LEFT/RIGHT #271

Closed
wants to merge 2 commits into from

Conversation

savend
Copy link

@savend savend commented Mar 24, 2021

There can be confusion because in the turtlebot3_core the goal_velocity[2] array is given with [LINEAR=0] and [ANGULAR=1] and in the turtlebot3_motor_driver it was received with [LEFT=0] and [RIGHT=1].
Alternative is to define LINEAR 0 and ANGULAR 1 in the turtlebot3_motor_driver.h.

A little detail who can help understanding the code.

There can be confusion because in the turtlebot3_core the goal_velocity[2] array is given with [LINEAR=0] and [ANGULAR=1] and in the turtlebot3_motor_driver it was received with [LEFT=0] and [RIGHT=1]. A little detail who can help understanding the code.
Alternative is to define LINEAR 0 and ANGULAR 1 in the turtlebot3_motor_driver.h.
@ROBOTIS-Will
Copy link
Contributor

hi @savend
Thank you for your contribution.
This change has been applied and waiting to be merged into master soon.
6be8610
Thanks!

@ROBOTIS-Will ROBOTIS-Will mentioned this pull request May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants