diff --git a/CMakeLists.txt b/CMakeLists.txt index 2fd18fce13..3a15bf13e4 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -91,8 +91,7 @@ option(BUILD_SHARED_LIBS "Create shared libraries" ON) if(MIOPEN_ENABLE_SQLITE) # MIOpen now depends on SQLite as well - find_package(PkgConfig) - pkg_check_modules(SQLITE3 REQUIRED sqlite3) + find_package(SQLite3 REQUIRED) endif() find_package(BZip2) find_package(nlohmann_json 3.9.1 REQUIRED) diff --git a/cmake/Findzstd.cmake b/cmake/Findzstd.cmake deleted file mode 100644 index 43ea6f9b40..0000000000 --- a/cmake/Findzstd.cmake +++ /dev/null @@ -1,91 +0,0 @@ -################################################################################ -# -# MIT License -# -# Copyright (c) 2023 Advanced Micro Devices, Inc. -# -# Permission is hereby granted, free of charge, to any person obtaining a copy -# of this software and associated documentation files (the "Software"), to deal -# in the Software without restriction, including without limitation the rights -# to use, copy, modify, merge, publish, distribute, sublicense, and/or sell -# copies of the Software, and to permit persons to whom the Software is -# furnished to do so, subject to the following conditions: -# -# The above copyright notice and this permission notice shall be included in all -# copies or substantial portions of the Software. -# -# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR -# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, -# FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE -# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER -# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, -# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE -# SOFTWARE. -# -################################################################################ - -# Try to find the zstd library -# -# If successful, the following variables will be defined: -# zstd_INCLUDE_DIR -# zstd_LIBRARY -# zstd_STATIC_LIBRARY -# zstd_FOUND -# -# Additionally, one of the following import targets will be defined: -# zstd::libzstd_shared -# zstd::libzstd_static - -if(MSVC) - set(zstd_STATIC_LIBRARY_SUFFIX "_static\\${CMAKE_STATIC_LIBRARY_SUFFIX}$") -else() - set(zstd_STATIC_LIBRARY_SUFFIX "\\${CMAKE_STATIC_LIBRARY_SUFFIX}$") -endif() - -find_path(zstd_INCLUDE_DIR NAMES zstd.h) -find_library(zstd_LIBRARY NAMES zstd zstd_static) -find_library(zstd_STATIC_LIBRARY NAMES - zstd_static - "${CMAKE_STATIC_LIBRARY_PREFIX}zstd${CMAKE_STATIC_LIBRARY_SUFFIX}") - -include(FindPackageHandleStandardArgs) -find_package_handle_standard_args( - zstd DEFAULT_MSG - zstd_LIBRARY zstd_INCLUDE_DIR -) - -if(zstd_FOUND) - if(zstd_LIBRARY MATCHES "${zstd_STATIC_LIBRARY_SUFFIX}$") - set(zstd_STATIC_LIBRARY "${zstd_LIBRARY}") - elseif (NOT TARGET zstd::libzstd_shared) - add_library(zstd::libzstd_shared SHARED IMPORTED) - if(MSVC) - # IMPORTED_LOCATION is the path to the DLL and IMPORTED_IMPLIB is the "library". - get_filename_component(zstd_DIRNAME "${zstd_LIBRARY}" DIRECTORY) - string(REGEX REPLACE "${CMAKE_INSTALL_LIBDIR}$" "${CMAKE_INSTALL_BINDIR}" zstd_DIRNAME "${zstd_DIRNAME}") - get_filename_component(zstd_BASENAME "${zstd_LIBRARY}" NAME) - string(REGEX REPLACE "\\${CMAKE_LINK_LIBRARY_SUFFIX}$" "${CMAKE_SHARED_LIBRARY_SUFFIX}" zstd_BASENAME "${zstd_BASENAME}") - set_target_properties(zstd::libzstd_shared PROPERTIES - INTERFACE_INCLUDE_DIRECTORIES "${zstd_INCLUDE_DIR}" - IMPORTED_LOCATION "${zstd_DIRNAME}/${zstd_BASENAME}" - IMPORTED_IMPLIB "${zstd_LIBRARY}") - unset(zstd_DIRNAME) - unset(zstd_BASENAME) - else() - set_target_properties(zstd::libzstd_shared PROPERTIES - INTERFACE_INCLUDE_DIRECTORIES "${zstd_INCLUDE_DIR}" - IMPORTED_LOCATION "${zstd_LIBRARY}") - endif() - endif() - if(zstd_STATIC_LIBRARY MATCHES "${zstd_STATIC_LIBRARY_SUFFIX}$" AND - NOT TARGET zstd::libzstd_static) - add_library(zstd::libzstd_static STATIC IMPORTED) - set_target_properties(zstd::libzstd_static PROPERTIES - INTERFACE_INCLUDE_DIRECTORIES "${zstd_INCLUDE_DIR}" - IMPORTED_LOCATION "${zstd_STATIC_LIBRARY}") - endif() -endif() - -unset(zstd_STATIC_LIBRARY_SUFFIX) - -mark_as_advanced(zstd_INCLUDE_DIR zstd_LIBRARY zstd_STATIC_LIBRARY) diff --git a/docs/sphinx/requirements.in b/docs/sphinx/requirements.in index ee7a8d0d9e..5ab9e9085e 100644 --- a/docs/sphinx/requirements.in +++ b/docs/sphinx/requirements.in @@ -1 +1 @@ -rocm-docs-core==0.30.1 +rocm-docs-core==0.30.2 diff --git a/docs/sphinx/requirements.txt b/docs/sphinx/requirements.txt index ce13fde525..454c8157d0 100644 --- a/docs/sphinx/requirements.txt +++ b/docs/sphinx/requirements.txt @@ -100,7 +100,7 @@ requests==2.31.0 # via # pygithub # sphinx -rocm-docs-core==0.30.1 +rocm-docs-core==0.30.2 # via -r requirements.in smmap==5.0.0 # via gitdb diff --git a/requirements.txt b/requirements.txt index 2c81433131..8a81242667 100755 --- a/requirements.txt +++ b/requirements.txt @@ -1,5 +1,6 @@ sqlite3@3.43.2 -DCMAKE_POSITION_INDEPENDENT_CODE=On boost@1.83 -DCMAKE_POSITION_INDEPENDENT_CODE=On --build -DCMAKE_CXX_FLAGS=" -std=c++14 -Wno-enum-constexpr-conversion -Wno-deprecated-builtins -Wno-deprecated-declarations " +facebook/zstd@v1.4.5 -X subdir -DCMAKE_DIR=build/cmake ROCmSoftwarePlatform/half@10abd99e7815f0ca5d892f58dd7d15a23b7cf92c --build ROCmSoftwarePlatform/rocMLIR@rocm-5.5.0 -H sha256:a5f62769d28a73e60bc8d61022820f050e97c977c8f6f6275488db31512e1f42 -DBUILD_FAT_LIBROCKCOMPILER=1 -DCMAKE_IGNORE_PATH=/opt/conda/envs/py_3.9 -DCMAKE_IGNORE_PREFIX_PATH=/opt/conda nlohmann/json@v3.11.2 -DJSON_MultipleHeaders=ON -DJSON_BuildTests=Off diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt index 1d5548db7e..535ead20a6 100644 --- a/src/CMakeLists.txt +++ b/src/CMakeLists.txt @@ -829,12 +829,7 @@ endif() ####################################### if(MIOPEN_ENABLE_SQLITE) # MIOpen depends on SQLite - target_include_directories(MIOpen SYSTEM PRIVATE ${SQLITE3_STATIC_INCLUDE_DIRS}) - target_include_directories(MIOpen SYSTEM INTERFACE $) - target_compile_options(MIOpen PRIVATE ${SQLITE3_STATIC_CFLAGS}) - target_compile_options(MIOpen INTERFACE $) - target_link_libraries(MIOpen PRIVATE ${SQLITE3_STATIC_LDFLAGS}) - target_link_libraries(MIOpen INTERFACE $) + target_link_libraries(MIOpen PRIVATE SQLite::SQLite3) endif() ############################################################ # MIOpen depends on librt for Boost.Interprocess diff --git a/src/sqlite/CMakeLists.txt b/src/sqlite/CMakeLists.txt index 823a44cb7a..2e3d69b55c 100644 --- a/src/sqlite/CMakeLists.txt +++ b/src/sqlite/CMakeLists.txt @@ -34,7 +34,7 @@ target_compile_options(sqlite_memvfs PRIVATE $<$:-Wno-everything> $<$:-w>) -target_include_directories(sqlite_memvfs SYSTEM PRIVATE ${SQLITE3_STATIC_INCLUDE_DIRS}) +target_link_libraries(sqlite_memvfs PRIVATE SQLite::SQLite3) # set_target_properties( # sqlite_memvfs # PROPERTIES