Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt Google Style Guide for C++ in order to improve consistency in coding style #2482

Closed
amberhassaan opened this issue Oct 25, 2023 · 2 comments

Comments

@amberhassaan
Copy link
Contributor

As the title says Google Style Guide for C++ is fairly detailed down to how to name methods and class members. I personally don't agree with everything it has to offer but I'm hoping that we can all agree to use it so that we don't need to have any code style discussions.
Another goal is to improve the quality of the code (in addition to style) in terms of abstraction, robustness and performance (The style guide has a small number of recommendations on that front).

We can also make agreed upon deviations from the style guide when necessary as long as we document it here or some other document.

@junliume @JehandadKhan @CAHEK7 @DrizztDoUrden @averinevg @atamazov @cderb @iq136boy @bghimireamd : please share your opinion. CC: @ROCmSoftwarePlatform/miopen-devs

@junliume
Copy link
Collaborator

@amberhassaan we may convert this issue into discussion.

@amberhassaan
Copy link
Contributor Author

oh, sorry, didn't know github has that feature. Let me move this to a discussion: #2483

Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants